tools/compare: don't actually discard valid (but zero) pvalue
#1733
+132
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LebedevRI
commented
Jan 6, 2024
tools/gbench/report.py
Outdated
Comment on lines
1508
to
1509
| json1["benchmarks"] = [json1["benchmarks"][0] | ||
| for i in range(1000)] |
There was a problem hiding this comment.
I assume we don't want a .json with 10k lines? :)
It's rather completely non-human-readable otherwise. I can't imagine the filesize really matters, and if it does, it should just be compressed later on.
So, this is embarressing. For a very large number of repetitions, we can end up with pvalue of a true zero, and it obviously compares false, and we treat it as-if we failed to compute it...
dmah42
approved these changes
Jan 8, 2024
|
good catch. thanks! |
|
@dmah42 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit embarrassing.
The test added in middle commit does not produce a pvalue,
because the pvalue is
0. Duh!