Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editable install by unsetting build_ext.copy_extensions_to_source #1710

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix editable install by unsetting build_ext.copy_extensions_to_source #1710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba00f42
Fix editable install by unsetting `build_ext.copy_extensions_to_source`
nicholasjng Dec 7, 2023
2128f59
Merge branch 'main' into editable-fix
dmah42 Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ def run(self):
# explicitly call `bazel shutdown` for graceful exit
self.spawn(["bazel", "shutdown"])

def copy_extensions_to_source(self):
"""
Copy generated extensions into the source tree.
This is done in the ``bazel_build`` method, so it's not necessary to
do again in the `build_ext` base class.
"""
pass

def bazel_build(self, ext: BazelExtension) -> None:
"""Runs the bazel build to create the package."""
with temp_fill_include_path("WORKSPACE"):
Expand Down
Loading