Fix pre-commit GitHub Actions job
#1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, editable pip installs are now broken, which means that they will break the pre-commit workflow due to the `pip install -e .` instruction. Since the normal install is unaffected, we can just drop the `-e` switch. It does not matter which mode is used, since the environment is only used for linting.
dmah42
approved these changes
Dec 6, 2023
|
Test failure (timeout in gtest) seems to be a flake? |
rerunning to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, editable pip installs are now broken, which means that they will break the pre-commit workflow due to the
pip install -e .instruction.Since the normal install is unaffected, we can just drop the
-eswitch. It does not matter which mode is used, since the environment is only used for linting.I debugged a little bit, and found the reason why editable installs do not work right now - I just have not figured out a way to
change the Bazel extension class to do the right thing yet. (Debugging
setuptoolsis not nice, since a lot of the package is stub files, and each entry point loads a different command).