-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory manager result bug #1941
base: main
Are you sure you want to change the base?
Conversation
Yep, something like this should work i suppose. |
Hm, and the msvc failures seem real, probably need to explicitly cast something in tests from |
Looks like more casts are needed :) |
Hmm, those msvc failure look weird. I don't think this PR can cause them. |
I reproduced the failure on my Windows computer. I don’t understand why, but it seems like the failure is caused by my PR. e1eaa52 may help. |
Fixes #1939