Skip to content

Compose benchmark app crud #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented May 13, 2025

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2812

Based on #2817

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@LZRS LZRS force-pushed the compose-benchmark-app-crud branch from 9154026 to 82aaf22 Compare May 22, 2025 22:41
@LZRS LZRS marked this pull request as ready for review May 23, 2025 05:13
@LZRS LZRS requested a review from a team as a code owner May 23, 2025 05:13
@LZRS LZRS requested a review from MJ1998 May 23, 2025 05:13
@LZRS LZRS force-pushed the compose-benchmark-app-crud branch from 82aaf22 to 3840a55 Compare May 23, 2025 10:07
@LZRS LZRS force-pushed the compose-benchmark-app-crud branch from 82aaf22 to 51a121d Compare May 23, 2025 10:13
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need runBlocking because of the usage of measureTime and measureTimedValue.
Because the flow of execution is anyway sequential and if these functions were suspend then we wouldn't need the runBlocking.
I would recommend to manually capture the duration in a suspended helper function instead of using measureTime, measureTimedValue. - This way you can avoid using runBlocking.

@LZRS
Copy link
Collaborator Author

LZRS commented May 27, 2025

Do we need runBlocking because of the usage of measureTime and measureTimedValue. Because the flow of execution is anyway sequential and if these functions were suspend then we wouldn't need the runBlocking. I would recommend to manually capture the duration in a suspended helper function instead of using measureTime, measureTimedValue. - This way you can avoid using runBlocking.

Cool, yeah that makes sense.

@LZRS
Copy link
Collaborator Author

LZRS commented May 27, 2025

@MJ1998 I've updated the PR to include the changes you suggested

@LZRS LZRS requested a review from MJ1998 May 27, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Benchmark FhirEngine CRUD API methods in app
2 participants