-
Notifications
You must be signed in to change notification settings - Fork 310
Compose benchmark app crud #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9154026
to
82aaf22
Compare
82aaf22
to
3840a55
Compare
82aaf22
to
51a121d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need runBlocking
because of the usage of measureTime
and measureTimedValue
.
Because the flow of execution is anyway sequential and if these functions were suspend then we wouldn't need the runBlocking.
I would recommend to manually capture the duration in a suspended helper function instead of using measureTime, measureTimedValue. - This way you can avoid using runBlocking.
...nchmarks/app/src/main/java/com/google/android/fhir/engine/benchmarks/app/CrudApiViewModel.kt
Outdated
Show resolved
Hide resolved
...enchmarks/app/src/main/java/com/google/android/fhir/engine/benchmarks/app/BenchmarkResult.kt
Outdated
Show resolved
Hide resolved
...nchmarks/app/src/main/java/com/google/android/fhir/engine/benchmarks/app/CrudApiViewModel.kt
Outdated
Show resolved
Hide resolved
Cool, yeah that makes sense. |
@MJ1998 I've updated the PR to include the changes you suggested |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2812
Based on #2817
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)

Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.