Include the associated header from vendor_dlkm_utils.cc
#1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemoreira
approved these changes
Nov 27, 2025
While writing google#1850 I ran into an issue that the compiler didn't check return type mismatches between the same function, leading to segfaults at runtime. Including the header makes the functions explicitly conflict. Bug: b/464088042
Databean
force-pushed
the
vendor_dlkm_utils_header
branch
from
49b5550 to
1ab944c
Compare
Member
Author
|
Thanks for reviewing! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing #1850 I ran into an issue that the compiler didn't check return type mismatches between the same function, leading to segfaults at runtime.
Including the header makes the functions explicitly conflict.
Bug: b/464088042