Skip to content

Conversation

@yarolegovich
Copy link
Member

The changes are mostly test updates.

  • If Actions.Escalate was set on a session.Event it will be passed to callers in the terminal task status update Metadata.
  • RemoteAgent will set it back as Actions.Event (handled in adka2a.ToSessionEvent).

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yarolegovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to reliably transmit the 'escalate' status across the Agent-to-Agent (A2A) communication boundary. This ensures that if an agent's session event is marked for escalation, this critical status is preserved and communicated to downstream callers via the terminal task status update metadata, allowing for appropriate handling and response.

Highlights

  • Escalate Status Propagation: Implemented a mechanism to pass the Escalate status from session.Event.Actions through the A2A communication layer, ensuring it's included in terminal task status updates.
  • A2A Message Metadata: Modified EventToMessage to serialize the Escalate flag into the a2a.Message metadata and updated ToSessionEvent to deserialize it back into session.Event.Actions.
  • Event Processor Updates: The eventProcessor now tracks the Escalate status across events and ensures it is correctly included in the metadata of the final terminal task status update.
  • Comprehensive Testing: Added new test cases and updated existing ones in a2a_agent_test.go, events_test.go, and processor_test.go to validate the end-to-end propagation and handling of the Escalate status.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces functionality to pass an escalate status through the A2A protocol. The changes involve adding an escalate flag to the A2A message metadata when a session.Event has Actions.Escalate set. The server-side processor tracks this flag across multiple events and ensures it's included in the final terminal event. This allows the remote agent to reconstruct the escalate action correctly. The implementation is accompanied by thorough test updates, including new test cases for the escalation flow. The changes are logical and well-implemented. I have one suggestion for improving the robustness of metadata handling.

@yarolegovich yarolegovich changed the title feat: pass escalate status through a2a feat: pass event actions through a2a Nov 17, 2025
@linikerruan3-gif linikerruan3-gif mentioned this pull request Nov 20, 2025
Closed
@yarolegovich yarolegovich merged commit d197968 into main Nov 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants