fix: update ADK setup link and add .env file location note in MCPTools. #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavinigam-gcp
added a commit
that referenced
this pull request
May 30, 2025
…flicts, we are doing all those small changes in this PR. Each changes are listed below: - #254 docs/sessions/session.md -> …part of session object's identification. In the session object identification description, it was unclear (for first time readers), what exactly is id, and app_name and how they are different. Added some examples according to my own understanding. Please change accordingly if you feel so. Thanks. - #252 Multiple files: quickstart-streaming.md, quickstart.md, mcp-tools.md add an option in the CLI to enable or disable the reload feature. So users(esp. windows) can disable this if they come across the '_make_subprocess_transport NotImplementedError' bug on windows. - #179 docs/agents/models.md -> Add Windows Encoding Note for LiteLLM When using ADK agents with LiteLlm on Windows, users might encounter a UnicodeDecodeError: 'charmap' codec can't decode byte... error. This often happens when litellm (used by LiteLlm) tries to read cached files (like model pricing information) using the default Windows encoding (cp1252) instead of UTF-8. - #170 docs/tools/mcp-tools.md fix: update ADK setup link and add .env file location note in MCPTools. Also resolved the issue: #169
lavinigam-gcp
added a commit
that referenced
this pull request
May 30, 2025
…flicts, we are doing all those small changes in this PR. Each changes are listed below: (#342) - #254 docs/sessions/session.md -> …part of session object's identification. In the session object identification description, it was unclear (for first time readers), what exactly is id, and app_name and how they are different. Added some examples according to my own understanding. Please change accordingly if you feel so. Thanks. - #252 Multiple files: quickstart-streaming.md, quickstart.md, mcp-tools.md add an option in the CLI to enable or disable the reload feature. So users(esp. windows) can disable this if they come across the '_make_subprocess_transport NotImplementedError' bug on windows. - #179 docs/agents/models.md -> Add Windows Encoding Note for LiteLLM When using ADK agents with LiteLlm on Windows, users might encounter a UnicodeDecodeError: 'charmap' codec can't decode byte... error. This often happens when litellm (used by LiteLlm) tries to read cached files (like model pricing information) using the default Windows encoding (cp1252) instead of UTF-8. - #170 docs/tools/mcp-tools.md fix: update ADK setup link and add .env file location note in MCPTools. Also resolved the issue: #169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to issue #169
Fix the issue according to the method mentioned in the issue.