web: js: trim values before passing to wasm#244
Merged
Conversation
User input values are currently directly passed to wasm as long as they are more than 0 characters long. This also means that having an ascii whitespace leads to input being invalid. This patch introduces trimming before passing it to wasm and also before saving it in the url. So sharing the url is also safe. Signed-off-by: Prashant Rahul <prashantrahul141@protonmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 16.25% 16.25%
=======================================
Files 26 26
Lines 1741 1741
Branches 1741 1741
=======================================
Hits 283 283
Misses 1438 1438
Partials 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
qwandor
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User input values are currently directly passed to wasm as long as they are more than 0 characters long. This also means that having an ascii whitespace leads to input being invalid.
This patch introduces trimming before passing it to wasm and also before saving it in the url. So sharing the url is also safe.
Side note: I used an intermediate
valuebecause updating{register}.valuemakes it impossible to type any ascii whitespaces in the input box. It does sound nice but in my opinion, it feels too restrictive.closes #239