Add RVV qs8/qu8 gavgpool kernels, configs and tests. #7031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarchard
reviewed
Sep 6, 2024
cmake/gen/rvv_microkernels.cmake
Outdated
| @@ -44,8 +44,12 @@ SET(PROD_RVV_MICROKERNEL_SRCS | |||
| src/f32-vlrelu/gen/f32-vlrelu-rvv-u4v.c | |||
| src/f32-vrelu/gen/f32-vrelu-rvv-u4v.c | |||
| src/f32-vrsqrt/gen/f32-vrsqrt-rvv-rsqrt-u4v.c | |||
| src/qs8-gavgpool/gen/qs8-gavgpool-7p7x-minmax-fp32-rvv-c2v.c | |||
There was a problem hiding this comment.
c2v function/file naming inconsistent with rvv kernels
should be u2v meaning unrolled to 2 vectors.. aka m2
There was a problem hiding this comment.
f32 gavgpool uses the old style naming as well, should get fixed
oliIMG
changed the title
fbarchard
approved these changes
Sep 9, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
-- bc650ef by Mihai.Olinovici <[email protected]>: Add qs8/qu8 gavgpool kernels, configs and tests. -- b0cfeb2 by Mihai.Olinovici <[email protected]>: Adhere to standard RVV naming. -- 8c941c0 by Mihai.Olinovici <[email protected]>: Remove old unipass reminants. FUTURE_COPYBARA_INTEGRATE_REVIEW=#7031 from imaginationtech:img_patch25_qs8_gavgpool 8c941c0 PiperOrigin-RevId: 672712922
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
-- bc650ef by Mihai.Olinovici <[email protected]>: Add qs8/qu8 gavgpool kernels, configs and tests. -- b0cfeb2 by Mihai.Olinovici <[email protected]>: Adhere to standard RVV naming. -- 8c941c0 by Mihai.Olinovici <[email protected]>: Remove old unipass reminants. FUTURE_COPYBARA_INTEGRATE_REVIEW=#7031 from imaginationtech:img_patch25_qs8_gavgpool 8c941c0 PiperOrigin-RevId: 672712922
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
-- bc650ef by Mihai.Olinovici <[email protected]>: Add qs8/qu8 gavgpool kernels, configs and tests. -- b0cfeb2 by Mihai.Olinovici <[email protected]>: Adhere to standard RVV naming. -- 8c941c0 by Mihai.Olinovici <[email protected]>: Remove old unipass reminants. FUTURE_COPYBARA_INTEGRATE_REVIEW=#7031 from imaginationtech:img_patch25_qs8_gavgpool 8c941c0 PiperOrigin-RevId: 672712922
|
We are currently working on deprecating gavgpool and replacing it with static_mean, which is a generalization of gavgpool. I suggest directing your efforts towards implementing rsum and rdsum (which implement static_mean) rather than gavgpool. |
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
-- bc650ef by Mihai.Olinovici <[email protected]>: Add qs8/qu8 gavgpool kernels, configs and tests. -- b0cfeb2 by Mihai.Olinovici <[email protected]>: Adhere to standard RVV naming. -- 8c941c0 by Mihai.Olinovici <[email protected]>: Remove old unipass reminants. -- 8304b4d by Mihai.Olinovici <[email protected]>: Regenerate make files. FUTURE_COPYBARA_INTEGRATE_REVIEW=#7031 from imaginationtech:img_patch25_qs8_gavgpool 8304b4d PiperOrigin-RevId: 672712922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.