Fixes img/sec/core.#280
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
copybara-service
Bot
force-pushed
the
test_555396130
branch
2 times, most recently
from
6e76888 to
ebbd1f2
Compare
Before this fix, only `lt0` but not `lstep` was updated after computing an evaluation, which led to a img/sec/core computation that was too high. Tis fix simply adds the time needed to eval / checkpoint to `lt0`, correcting the `dt` term in the `dsteps/dt` computation. PiperOrigin-RevId: 555396130
copybara-service
Bot
force-pushed
the
test_555396130
branch
from
ebbd1f2 to
20b09fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes img/sec/core.
Before this fix, only
lt0but notlstepwas updated after computing an evaluation, which led to a img/sec/core computation that was too high. Tis fix simply adds the time needed to eval / checkpoint tolt0, correcting thedtterm in thedsteps/dtcomputation.