Skip to content

Update code for exact match to resolve a bug. #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update code for exact match to resolve a bug. #887

copybara-service wants to merge 1 commit into from

Conversation

@copybara-service
Copy link
Contributor

@copybara-service copybara-service bot commented Sep 3, 2021

Update code for exact match to resolve a bug.

@google-cla
Copy link

google-cla bot commented Sep 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 3, 2021
craffel
craffel reviewed Sep 3, 2021
View reviewed changes
t5/evaluation/metrics.py
return {
"exact_match":
100 * np.mean(
np.char.equal([str(t.strip()) for t in targets],
Copy link
Contributor

@craffel craffel Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding strip() changes the behavior of this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@craffel craffel craffel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@craffel