Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code calculates the metrics incorrectly.
PSNR (Mathematical Correction): The original code computed a global average MSE across the entire 5D video tensor (B, C, T, H, W) before converting to log space. This made the evaluation strictly batch-size dependent. Furthermore, because logarithms are non-linear, averaging linear MSE values yields a mathematically different result than averaging per-sample decibel values. The fix computes the MSE per sample, converts each to PSNR individually, and then averages the resulting values.
MS_SSIM (Shape Mismatch Fix): The original code passed a 5D video tensor (B, C, T, H, W) to
ms_ssim, which expects a standard 4D image batch (N, C, H, W). Flattening the time dimension into the batch dimension resolves this structural bug.LPIPS (Redundant Normalization): Eliminated unnecessary computation where the data was scaled to [0, 1] only to be mapped back to [-1, 1] for the LPIPS forward pass.