Conversation
Summary of ChangesHello @wt17, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the documentation in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to clarify which models are supported by the Gemini Developer API and which are supported by Vertex AI. This is a useful clarification for users. However, the application does not currently validate the chosen model against the selected environment (Gemini API vs. Vertex AI), which can lead to runtime errors if an unsupported combination is used. I've added a comment to the README.md suggesting that argument handling be improved to prevent this and provide a better user experience.
| You can choose the model to use by specifying the ```--model <model name>``` flag. Available options on Gemini Developer API and Vertex AI Client: | ||
|
|
||
| - `gemini-2.5-computer-use-preview-10-2025`: This is the default model. | ||
|
|
||
| Available options on Gemini Developer API only: | ||
|
|
||
| - `gemini-3-flash-preview`: The preview version of Gemini 3 Flash. | ||
| - `gemini-3-pro-preview`: The preview version of Gemini 3 Pro. |
There was a problem hiding this comment.
While this clarification is helpful, the application code does not enforce these model restrictions based on the selected environment (Gemini Developer API vs. Vertex AI). The --model argument accepts all listed models regardless of the environment, which can lead to runtime errors if an invalid combination is chosen. To improve user experience, consider adding logic to main.py to validate that the selected model is compatible with the chosen environment. For example, after parsing arguments, you could check the USE_VERTEXAI environment variable and raise an error if an incompatible model is selected.
No description provided.