Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @mquirosbloch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the README.md to clarify which models are available for the Gemini Developer API and Vertex AI. This is a good documentation improvement. My review includes one comment that points out an inconsistency between this new documentation and the code's behavior, suggesting a follow-up to add validation logic for a better user experience.
| You can choose the model to use by specifying the ```--model <model name>``` flag. Available options on Gemini Developer API and Vertex AI Client: | ||
|
|
||
| - `gemini-2.5-computer-use-preview-10-2025`: This is the default model. | ||
|
|
||
| Available options on Gemini Developer API only: | ||
|
|
||
| - `gemini-3-flash-preview`: The preview version of Gemini 3 Flash. | ||
| - `gemini-3-pro-preview`: The preview version of Gemini 3 Pro. |
There was a problem hiding this comment.
This is a helpful clarification in the documentation. However, it highlights an inconsistency with the current implementation in main.py. The code doesn't prevent a user from selecting a model that is incompatible with their chosen client (e.g., selecting a Gemini Developer API-only model while using the Vertex AI client). This will lead to a runtime error instead of a graceful failure with a clear error message.
To improve the user experience, I recommend adding validation in main.py to check for compatible model and client combinations. This would provide an immediate and clear error to the user if they make an invalid selection. This can be addressed in a follow-up.
|
|
||
| **Available Models:** | ||
|
|
||
| You can choose the model to use by specifying the ```--model <model name>``` flag. Available options: |
No description provided.