test: add unit tests for BFS construction#5
Open
Pratz1337 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
test: add unit tests for BFS construction#5Pratz1337 wants to merge 1 commit intogoogle-deepmind:mainfrom
Pratz1337 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
- Adds comprehensive unit tests for strategicwm._src.se.construction.bfs. - Covers get_child, add_terminal_node, and the main bfs loop using mocks.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
fixed CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
Description
The
_src/se/construction/bfs.pymodule is critical for game tree generation but currently lacks unit test coverage.Changes
This PR adds
_src/se/construction/bfs_test.pyto verify:get_childbehavior for terminal and non-terminal nodes.add_terminal_nodegraph updates.bfsexecution loop using mocks.