Skip to content

Enhanced Centralized Logging System#10

Open
hmshuv wants to merge 2 commits intogoogle-deepmind:mainfrom
hmshuv:feature/enhanced-logging
Open

Enhanced Centralized Logging System#10
hmshuv wants to merge 2 commits intogoogle-deepmind:mainfrom
hmshuv:feature/enhanced-logging

Conversation

@hmshuv
Copy link

@hmshuv hmshuv commented Dec 22, 2025


title: Enhanced Centralized Logging System
labels: [enhancement, logging]
base: main
head: enhanced-logging-system

Enhanced Centralized Logging System

Summary

Replaces ad-hoc print statements with standardized Python logging across the library, enabling better verbosity control and programmatic log capture.

Changes

New Module:

  • Added strategicwm/_src/logging_utils.py with get_logger() and configure_logging() functions

Refactored Modules:

  • strategicwm/_src/client_lib.py
  • strategicwm/_src/se/construction/direct.py
  • strategicwm/_src/se/construction/bfs.py

Testing:

  • Added strategicwm/_src/logging_utils_test.py

Motivation

Replaces inconsistent print statements with standard Python logging, allowing users to:

  • Control log verbosity via logging configuration
  • Capture logs programmatically
  • Get timestamped, leveled output for better debugging

Related Issue

Closes #9

Type of Change

  • New feature (non-breaking change)
  • Documentation update

Usage Example

import logging
from strategicwm import configure_logging

configure_logging(level=logging.DEBUG)

Checklist

  • Code follows project style guidelines
  • Self-reviewed code
  • Added comments where needed
  • Added tests and all tests pass
  • Documentation updated

Ready for review! Let me know if you have any questions or feedback.

- Add logging_utils module
- Update client_lib, direct, and bfs to use logger
- Add tests for logging configuration
@google-cla
Copy link

google-cla bot commented Dec 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hmshuv
Copy link
Author

hmshuv commented Dec 22, 2025

fixed CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhanced Centralized Logging System

1 participant