Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing to increase format of output other than html. #50

Merged
merged 5 commits into from
Aug 4, 2014

Conversation

gongo
Copy link
Owner

@gongo gongo commented Aug 4, 2014

Motivation

GH-33 and GH-48

Work

Split RSpec::Core::Formatters::TurnipFormatter into following classes:

  • RSpec::Core::Formatters::TurnipBaseFormatter
  • RSpec::Core::Formatters::TurnipHtmlFormatter
module RSpec
  module Core
    module Formatters
      class TurnipHtmlFormatter < TurnipBaseFormatter
      end
    end
  end
end

RSpecTurnipHtmlFormatter = RSpec::Core::Formatters::TurnipHtmlFormatter
RSpecTurnipFormatter = RSpec::Core::Formatters::TurnipHtmlFormatter # For compatibility

Future

module RSpec
  module Core
    module Formatters
      # GH-48
      class TurnipJsonFormatter < TurnipBaseFormatter
      end

      # GH-33
      class TurnipTextFormatter < TurnipBaseFormatter
      end
    end
  end
end

@gongo gongo self-assigned this Aug 4, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.27%) when pulling 630ffb3 on turnip_base_formatter into 44b9284 on release/0.3.2.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.27%) when pulling 630ffb3 on turnip_base_formatter into 44b9284 on release/0.3.2.

gongo added a commit that referenced this pull request Aug 4, 2014
Preparing to increase format of output other than html.
@gongo gongo merged commit a9bba85 into release/0.3.2 Aug 4, 2014
@gongo gongo deleted the turnip_base_formatter branch August 4, 2014 19:39
@gongo
Copy link
Owner Author

gongo commented Aug 4, 2014

This branch might be be erased maybe ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants