Automated fix for refs/heads/rebase_20240329#1
Open
github-actions[bot] wants to merge 1883 commits intorebase_20240329from
Open
Automated fix for refs/heads/rebase_20240329#1github-actions[bot] wants to merge 1883 commits intorebase_20240329from
github-actions[bot] wants to merge 1883 commits intorebase_20240329from
Conversation
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35744 COPYBARA_INTEGRATE_REVIEW=grpc#35744 from tanvi-jagtap:tjagtap_formatting_1017 846efda PiperOrigin-RevId: 602911628
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35743 COPYBARA_INTEGRATE_REVIEW=grpc#35743 from tanvi-jagtap:tjagtap_formatting_1016 0d0d44f PiperOrigin-RevId: 602911751
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35739 COPYBARA_INTEGRATE_REVIEW=grpc#35739 from tanvi-jagtap:tjagtap_formatting_1012 f42c82e PiperOrigin-RevId: 602911916
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35738 COPYBARA_INTEGRATE_REVIEW=grpc#35738 from tanvi-jagtap:tjagtap_formatting_1011 d834abb PiperOrigin-RevId: 602912271
Gives a slightly cleaner API for Arena sizing Built on grpc#35732 Closes grpc#35765 COPYBARA_INTEGRATE_REVIEW=grpc#35765 from ctiller:chan2 e67e174 PiperOrigin-RevId: 602935918
This is meant for non googlers. PiperOrigin-RevId: 602963187
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35741 COPYBARA_INTEGRATE_REVIEW=grpc#35741 from tanvi-jagtap:tjagtap_formatting_1014 b8df832 PiperOrigin-RevId: 602963388
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35727 COPYBARA_INTEGRATE_REVIEW=grpc#35727 from tanvi-jagtap:tjagtap_2024_01_29_formatting_1005 b92d064 PiperOrigin-RevId: 602963496
…pc#35729) Fixes grpc#34844. Closes grpc#35729 COPYBARA_INTEGRATE_REVIEW=grpc#35729 from markdroth:retry_fix 899cb37 PiperOrigin-RevId: 603060248
… changes (grpc#35668) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Closes grpc#35675 COPYBARA_INTEGRATE_REVIEW=grpc#35675 from yashykt:UpdateGrpcCliDoc a62de28 PiperOrigin-RevId: 603095922
Please see cl/602800790 for details. Closes grpc#35775 COPYBARA_INTEGRATE_REVIEW=grpc#35775 from Vignesh2208:test-fix 95d3d93 PiperOrigin-RevId: 603138045
…ion (grpc#35776) One test (`CallerPollentsAreNotReferencedAfterCallbackIsRan`) was not waiting for a callback to be run before finishing when the EventEngine client is in use. With the iomgr implementation, `exec_ctx.Flush();` previously guaranteed that the callback would be executed before the test ended, but the EventEngine runs it in a separate thread, with the EventEngine shim providing its own isolated ExecCtx. This fix simply waits for the callback to be run before exiting, in the same way many other tests in this file wait on iomgr-based callback execution. Closes grpc#35776 COPYBARA_INTEGRATE_REVIEW=grpc#35776 from drfloob:httpcli-test-async 3c920da PiperOrigin-RevId: 603175531
…5583) Fix: grpc#35086 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35583 COPYBARA_INTEGRATE_REVIEW=grpc#35583 from XuanWang-Amos:fix_aio_eventloop aa0d207 PiperOrigin-RevId: 603188288
…/protoc.py pkg_resources deprecated in grpc_tools/protoc.py .venv/lib/python3.11/site-packages/grpc_tools/protoc.py:21: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html import pkg_resources Fix for [https://github.com/grpc/grpc/issues/33570](https://github.com/grpc/grpc/issues/33570) Closes grpc#35382 COPYBARA_INTEGRATE_REVIEW=grpc#35382 from fahadahammed:fix-33570 27429f7 PiperOrigin-RevId: 603189291
…ch fails to mark the socket as non blocking. See b/301618616 PiperOrigin-RevId: 603198514
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35757 COPYBARA_INTEGRATE_REVIEW=grpc#35757 from tanvi-jagtap:tjagtap_formatting_1030 931cf43 PiperOrigin-RevId: 603234762
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35756 COPYBARA_INTEGRATE_REVIEW=grpc#35756 from tanvi-jagtap:tjagtap_formatting_1029 1330c89 PiperOrigin-RevId: 603234878
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35755 COPYBARA_INTEGRATE_REVIEW=grpc#35755 from tanvi-jagtap:tjagtap_formatting_1028 022f3eb PiperOrigin-RevId: 603234961
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35754 COPYBARA_INTEGRATE_REVIEW=grpc#35754 from tanvi-jagtap:tjagtap_formatting_1027 386daf9 PiperOrigin-RevId: 603234985
Making screenshots for this doc better. This is meant for non googlers. PiperOrigin-RevId: 603266696
Fixing formatting issues in the doc This is meant for non googlers. PiperOrigin-RevId: 603268715
Fixing formatting issues in the doc This is meant for non googlers. PiperOrigin-RevId: 603270131
Change was created by the release automation script. See go/grpc-release. On top of changes made by the script, `setup.py` had to be updated to have `/std:c11` option for MSVC to use c11 features for boringssl. Closes grpc#35768 PiperOrigin-RevId: 603403329
PiperOrigin-RevId: 603424171
) Closes grpc#35783 COPYBARA_INTEGRATE_REVIEW=grpc#35783 from markdroth:client_channel_filter_rename ea8b74a PiperOrigin-RevId: 603424220
Closes grpc#35784 COPYBARA_INTEGRATE_REVIEW=grpc#35784 from markdroth:call_v3_experiment 2cabe8c PiperOrigin-RevId: 603435692
Closes grpc#35766 COPYBARA_INTEGRATE_REVIEW=grpc#35766 from ctiller:chan3 ea9a326 PiperOrigin-RevId: 603437058
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35787 COPYBARA_INTEGRATE_REVIEW=grpc#35787 from yijiem:fix-fork 703b8ae PiperOrigin-RevId: 603492379
Closes grpc#35673 COPYBARA_INTEGRATE_REVIEW=grpc#35673 from ananda1066:remove_exp 76257e0 PiperOrigin-RevId: 603734117
…36154) As per [gRFC A71](https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md). Closes grpc#36154 COPYBARA_INTEGRATE_REVIEW=grpc#36154 from eugeneo:xds-bootstrap-servers-env-var aada3e7 PiperOrigin-RevId: 617579604
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#36131 COPYBARA_INTEGRATE_REVIEW=grpc#36131 from yijiem:no-logging f3f6381 PiperOrigin-RevId: 617630514
I was surprised to see that the C++ core interprets "grpc-accept-encoding: deflate" like HTTP: it compresses messages using zlib with deflate compression, rather than using raw deflate. Matching HTTP semantics makes sense, of course, but this misnomer has historically confused HTTP implementations too. This detail didn't seem important enough to warrant inclusion in the main protocol specification, so I've proposed an addition to `docs/compression.md` to document the expected behavior. I'm happy to move the addition around if you'd prefer it elsewhere. Closes grpc#36113 COPYBARA_INTEGRATE_REVIEW=grpc#36113 from akshayjshah:deflate 9177d39 PiperOrigin-RevId: 617635558
Let's use Bazel 7 by default. Closes grpc#36105 PiperOrigin-RevId: 617653203
Broken in grpc#36116 Closes grpc#36152 COPYBARA_INTEGRATE_REVIEW=grpc#36152 from drfloob:fix/fix_build_deps/36116 e74054a PiperOrigin-RevId: 617721871
Adding testing for `Size()` on `MeshLabelsIterable` as promised on grpc#35371 This method doesn't get used the OTel C++ library at present so it was untested earlier, and bugs in its implementation were noticed later. To avoid that issue in the future, adding manual testing of this method. Changes - * Moved `MeshLabelsIterable` to the header to be able to test its Size method directly. Also had to move around some internals to be able to do so. * Replaced `absl::variant<grpc_core::Slice, StructPb> metadata_` from decoding the metadata lazily to just decoding it in the constructor. I don't remember the original thinking behind this. Maybe I wanted the decoding to happen lazily, but there doesn't seem to be much gain from doing it lazily, we instead have to deal with the overhead of `variant`. Closes grpc#35769 COPYBARA_INTEGRATE_REVIEW=grpc#35769 from yashykt:CsmMeshLabelsIterableSizeTesting ec9033b PiperOrigin-RevId: 617901839
Closes grpc#36150 COPYBARA_INTEGRATE_REVIEW=grpc#36150 from ctiller:drop-the-vowels 04d0422 PiperOrigin-RevId: 617958770
…ders (grpc#36148) These two things are different (event engine being a context has nothing to do with the ability to get a default event engine). Lumping them into the same header means that things that want the context also need to want the default event engine declarations, which in turn pull in CoreConfiguration -- which ultimately means that nothing that is depended on by CoreConfiguration can consume the event engine context, which is undesirable (and causing dependency loops in current work). Also includes an impressive number of cleanups to `grpc_base` because I ran `fix_build_deps` on that target as part of this. Closes grpc#36148 COPYBARA_INTEGRATE_REVIEW=grpc#36148 from ctiller:context-isnt-default--default-isnt-context a4fdad9 PiperOrigin-RevId: 617961015
… manifest (grpc#36080) grpc#35923 removed the use of mach_absolute_time in gpr. There is still one usage in protobuf, which they have removed the usage in protocolbuffers/protobuf#15554 but we haven't update yet. However gRPC library does not depends on protobuf but upb, so we should no longer need NSPrivacyAccessedAPICategorySystemBootTime any more. Closes grpc#36080 COPYBARA_INTEGRATE_REVIEW=grpc#36080 from HannahShiSFB:remove-privacy-for-mach_absolute_time dacccaf PiperOrigin-RevId: 617995787
Closes grpc#36164 COPYBARA_INTEGRATE_REVIEW=grpc#36164 from drfloob:again 8ab709d PiperOrigin-RevId: 618088552
…pc#36167) We've seen some recent crashes with the work_serializer_dispatch experiment where the picker is null when we try to do an LB pick. The only code-path we've found where the picker is set to null is the one triggered by the channel_idle filter, so we think we may be hitting a race condition where the call is started on the client_channel filter after the request to go idle has hit the WorkSerializer but before it has actually run. If that is the cause, then the right fix is to ensure that once we dispatch the request to go idle, we enqueue any subsequent RPC and dispatch a request to exit idle. However, that will require a bit of work, and it will be easier to do as part of the new call v3 channel stack, so we don't want to invest time in fixing this in the current implementation. For now, we add a work-around where we fail the RPC if the picker is null, which is better than crashing but not ideal. Closes grpc#36167 COPYBARA_INTEGRATE_REVIEW=grpc#36167 from markdroth:client_channel_idle_race_workaround 0207dd3 PiperOrigin-RevId: 618271781
Internal ref : b/324720620 Closes grpc#36168 COPYBARA_INTEGRATE_REVIEW=grpc#36168 from yashykt:FixStaticOrderInitFiasco 14f2a89 PiperOrigin-RevId: 618328195
…pc#36070) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#36070 COPYBARA_INTEGRATE_REVIEW=grpc#36070 from yijiem:grpc-metrics 7265372 PiperOrigin-RevId: 618529035
Remove rolled out experiments v3_compression_filter, v3_server_auth_filter; Extend WIP v3_channel_idle_filter for a bit, and extend work_serializer_clears_time_cache until OSS issues with work_serializer_dispatch are resolved. Closes grpc#36166 COPYBARA_INTEGRATE_REVIEW=grpc#36166 from ctiller:updat3 2c7223f PiperOrigin-RevId: 619057925
Closes grpc#36178 COPYBARA_INTEGRATE_REVIEW=grpc#36178 from markdroth:b64_remove 0139e3b PiperOrigin-RevId: 619288082
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#36179 COPYBARA_INTEGRATE_REVIEW=grpc#36179 from yousukseung:work-serializer-dispatch-extend cb47ee8 PiperOrigin-RevId: 619309808
…by ensuring no inline slices are created and returned by promise_endpoint. The PR also updates the transport to read padding and message in one read instead of two. PiperOrigin-RevId: 619374897
PiperOrigin-RevId: 619432986
…pc#36126) This removes two Executor::Run dependencies, and requires that all ServerCallbackCall implementations implement the new `RunAsync` method. There's one other known other implementation of ServerCallbackCall that will need to be updated. We could also support an "inefficient" path that uses the default engine (not implemented here), for all subclasses that do not want to update. As far as anyone is aware, the ServerCallbackCall class was never intended to be subclassed externally. Closes grpc#36126 COPYBARA_INTEGRATE_REVIEW=grpc#36126 from drfloob:server-callback-on-ee 6242a78 PiperOrigin-RevId: 619621598
Closes grpc#36181 COPYBARA_INTEGRATE_REVIEW=grpc#36181 from yashykt:RemoveRegisteredMethodLookupInTransport 3709bfa PiperOrigin-RevId: 619695276
Closes grpc#36183 COPYBARA_INTEGRATE_REVIEW=grpc#36183 from yashykt:OTelEnableDisableMetrics 948abe7 PiperOrigin-RevId: 6196968
Closes grpc#36186 COPYBARA_INTEGRATE_REVIEW=grpc#36186 from markdroth:xds_features_update 2299a1c PiperOrigin-RevId: 619940237
As title Closes grpc#36187 COPYBARA_INTEGRATE_REVIEW=grpc#36187 from apolcyn:vis_tag 6ce3930 PiperOrigin-RevId: 619955425
…tes on event engine endpoints which need to work with the chaotic good transport. PiperOrigin-RevId: 620089768
This PR is a follow up to this PR : grpc@2c49416 Flipping the flag to use absl logging instead of gpr_platform_log PiperOrigin-RevId: 620134323
golovasteek
force-pushed
the
rebase_20240329
branch
2 times, most recently
from
35b05fb to
dee6c8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PanCakes to the rescue!
We noticed that our 'sanity' test was going to fail, but we think we can fix that automatically, so we put together this PR to do just that!
If you'd like to opt-out of these PR's, add yourself to NO_AUTOFIX_USERS in .github/workflows/pr-auto-fix.yaml