cmd/link: improve PE section handling #76943

Zxilly · 2025-12-20T20:21:05Z

This change improves how the PE linker handles sections, laying
groundwork for proper section separation on Windows.

The peshbits function now handles section creation for all segment
types, similar to how elfshbits works for ELF.

This change improves how the PE linker handles sections: - Unify addSection and appendSection APIs following ELF pattern - Merge addDWARFSection into peshbits for consistent handling - Add peSectionAlign helper for section alignment - Add comprehensive unit tests for PE sections

gopherbot · 2025-12-20T20:26:05Z

This PR (HEAD: 22ce482) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731740.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-20T22:40:33Z

Message from Ian Lance Taylor:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-20T22:48:21Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-20T22:29:50Z","revision":"c2c4986d874bc02ee33e1595bcec6c2c3ad8a919"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-20T22:56:04Z

Message from Ian Lance Taylor:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-20T22:56:04Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 731740)

To reproduce, try gomote repro 8694925598940709329.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-20T22:56:05Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T07:09:18Z

Message from Zxilly Chou:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T09:15:52Z

Message from Zxilly Chou:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T09:16:02Z

This PR (HEAD: ce29298) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731740.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-21T10:27:10Z

Message from Meng Zhuo:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T10:34:56Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-21T10:20:46Z","revision":"0224e4fd103e5b4a68102e7941e51f4356cb1fc4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T10:42:35Z

Message from Meng Zhuo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T10:42:36Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/gotip-windows-386. Summary (view all results):

go on master (change 731740)

To reproduce, try gomote repro 8694880864650016401.

Additional links for debugging:

go tool dist test -json output [shard 3]

golang/try/gotip-windows-amd64. Summary (view all results):

go on master (change 731740)

To reproduce, try gomote repro 8694880864650016385.

Additional links for debugging:

go tool dist test -json output [shard 3]

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T10:42:36Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T12:09:56Z

This PR (HEAD: b4c33e7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731740.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-21T14:53:56Z

Message from xie cui:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T15:02:16Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T17:39:05Z

This PR (HEAD: de8228c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731740.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-21T18:47:16Z

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T18:47:17Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-21T18:33:42Z","revision":"5502e9c6ccb3bd17e1427e27b026e5e927c64af5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T19:03:52Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T19:03:53Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T19:03:54Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-21T22:54:19Z

Message from Ian Lance Taylor:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-22T18:02:33Z

This PR (HEAD: 7302f96) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731740.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-22T18:11:36Z

This PR (HEAD: ba62ab4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731740.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-22T18:20:33Z

Message from Zxilly Chou:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-22T22:08:28Z

Message from Ian Lance Taylor:

Patch Set 6: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-23T15:03:23Z

This PR (HEAD: a05a626) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731740.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-23T17:19:03Z

Message from Zxilly Chou:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-23T17:19:04Z

Message from Zxilly Chou:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-23T23:57:09Z

Message from Ian Lance Taylor:

Patch Set 7: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-23T23:57:09Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-23T23:47:44Z","revision":"1abfa5480da640af2d0c7bb562101f5415c8c25b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-24T00:14:00Z

Message from Ian Lance Taylor:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-24T00:14:00Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 731740)

To reproduce, try gomote repro 8694648906471063617.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-24T00:14:01Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/731740.
After addressing review feedback, remember to publish your drafts!

fix llvm link

ce29298

also check truncated name

b4c33e7

add comment

de8228c

Zxilly added 2 commits December 23, 2025 01:51

cmd/link: update PE section alignment handling

6ddeebf

cmd/link: refactor PE section creation method

7302f96

Zxilly added 2 commits December 23, 2025 02:05

cmd/link: add tests for PE section characteristics and alignment

9053771

cmd/link: adjust symbol name checks for 386 architecture

ba62ab4

cmd/link: update section alignment handling to use SectAlign method

a05a626

cmd/link: improve PE section handling #76943

Are you sure you want to change the base?

cmd/link: improve PE section handling #76943

Conversation

Zxilly commented Dec 20, 2025

Uh oh!

gopherbot commented Dec 20, 2025

Uh oh!

gopherbot commented Dec 20, 2025

Uh oh!

gopherbot commented Dec 20, 2025

Uh oh!

gopherbot commented Dec 20, 2025

Uh oh!

gopherbot commented Dec 20, 2025

Uh oh!

gopherbot commented Dec 20, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 21, 2025

Uh oh!

gopherbot commented Dec 22, 2025

Uh oh!

gopherbot commented Dec 22, 2025

Uh oh!

gopherbot commented Dec 22, 2025

Uh oh!

gopherbot commented Dec 22, 2025

Uh oh!

gopherbot commented Dec 23, 2025

Uh oh!

gopherbot commented Dec 23, 2025

Uh oh!

gopherbot commented Dec 23, 2025

Uh oh!

gopherbot commented Dec 23, 2025

Uh oh!

gopherbot commented Dec 23, 2025

Uh oh!

gopherbot commented Dec 24, 2025

Uh oh!

gopherbot commented Dec 24, 2025

Uh oh!

gopherbot commented Dec 24, 2025

Uh oh!

Reviewers

Assignees