-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
archive/zip, archive/tar: writer appends slash to directory names #71239
archive/zip, archive/tar: writer appends slash to directory names #71239
Conversation
This PR (HEAD: 4147c27) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642375. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from cong yin: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Song Gao: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
This PR (HEAD: d68d049) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642375. Important tips:
|
Message from cong yin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from cong yin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Song Gao: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Song Gao: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from cong yin: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
This PR (HEAD: 4e338b6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642375. Important tips:
|
Message from cong yin: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
This PR (HEAD: c5d79ca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642375. Important tips:
|
Message from cong yin: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Ian Lance Taylor: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-17T02:34:40Z","revision":"603fb7a30084c82dcad77e02070c27e9b9ba1413"} Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
This PR (HEAD: 0ebc591) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642375. Important tips:
|
Message from cong yin: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 7: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from cong yin: Patch Set 7: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
This PR (HEAD: 6e0fba0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/642375. Important tips:
|
Message from Jonathan Amsterdam: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from cong yin: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from cong yin: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from bcd a: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from bcd a: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from bcd a: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from cong yin: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 8: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Go LUCI: Patch Set 8: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-28T03:29:58Z","revision":"0e4c85481ea7041b2e3b669df72a69546f1e569e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Jonathan Amsterdam: Patch Set 8: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Go LUCI: Patch Set 8: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Message from Go LUCI: Patch Set 8: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642375. |
Fixes #71235 Change-Id: I62aebb9d421db0e4b57ad5cae25c70f47aa5f8f9 GitHub-Last-Rev: 6e0fba0 GitHub-Pull-Request: #71239 Reviewed-on: https://go-review.googlesource.com/c/go/+/642375 Reviewed-by: Jonathan Amsterdam <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/642375 has been merged. |
Fixes #71235