Add CellIndex intersection #98
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@jmr what else is necessary to make this mergeable? Do you want me to review? |
| // IntersectingLabels | ||
| // VisitIntersectingCells | ||
| // CellIndexIterator | ||
| func (c *CellIndex) IntersectingLabels(target CellUnion) []int32 { |
There was a problem hiding this comment.
Add the method comments from the C++
| rangeIter.Begin() | ||
|
|
||
| for ok := true; ok; ok = pos != len(target) { | ||
| if rangeIter.LimitID() <= target[pos].RangeMin() { |
There was a problem hiding this comment.
In C++ this was if rangeIter.LimitID() <= rangeIter.RangeMin() { is there a reason it's not like that here?
| } | ||
| } | ||
|
|
||
| pos++ |
There was a problem hiding this comment.
keep the C++ comments on this block as well
| id = id.ChildBegin() | ||
| } | ||
| } | ||
| target.Normalize() |
There was a problem hiding this comment.
The call to Normalize wasn't in the C++. Does removing this change the test outcomes?
Adds the methods
IntersectingLabelsandVisitIntersectingCellsas well as the testing.