Add missing methods on Edge #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the action and set up an initial configuration that passes on the codebase at this point in time.
Invalid Go toolchain version (1 result)
* go.mod#L0C0:0: As of Go 1.21, toolchain versions [must use the 1.N.P syntax](https://go.dev/doc/toolchain#version).
`1.21` in `go.mod` does not match this syntax and there is no additional `toolchain` directive, which may cause some `go` commands to fail.
(with comments on what the hash is representing
I couldn't find a better resource than https://github.com/dependabot/dependabot-core/blob/main/github_actions/spec/fixtures/workflow_files/pinned_sources_version_comments.yml to document what formats work.
Add comments on missing elements from C++ that need to be done.
alan-strohm
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
FYI, You might want to force your fork to match the upstream repos commit history at some point. This discussion explains how (but recreating the fork might be simpler?). I'm not sure if it matters. I think the current state might result in me getting added as an author for commits I had nothing to do with. 😛
|
Yes, I think my master became a feature branch not a tracking branch of the upstream after we switched to Squash and Merge. I'm trying to clear out my outstanding PR so I can reset and and get it back the right way. |
You don't have any outstanding PRs now. Anyway, it shouldn't matter. You can reset your main branch and rebase any other branches onto that. |
|
Yes, I rebased and everything is back to proper. |
abhinavdangeti
pushed a commit
to blevesearch/geo
that referenced
this pull request
May 8, 2025
shape.go had fallen behind C++. Added the missing edge methods. Add comments on what's left to catch back up. (This is needed for src/s2/internal/s2incident_edge_tracker to get to LegacyValidationQuery) --------- Co-authored-by: Alan Strohm <[email protected]>
abhinavdangeti
added a commit
to blevesearch/geo
that referenced
this pull request
May 12, 2025
Brings in all commits as of May 05, 2025: ``` * 4cab8bf dependabot[bot] | build(deps): bump golangci/golangci-lint-action from 7.0.0 to 8.0.0 and golangci-lint from v2.0 to v2.1 (golang#173) * c498f45 Robert Snedegar | builder_snapper: Update constants and comments (golang#172) * 18783dd Robert Snedegar | Update README.md and add CONTRIBUTING.md (golang#171) * 9edba9f dependabot[bot] | build(deps): bump github/codeql-action from 3.28.16 to 3.28.17 (golang#170) * 686492e Jesse Rosenstock | Test with 1.21 instead of 1.21.0 (golang#169) * 29adb2f Panmari | Run tests on a matrix of go versions (golang#168) * 6580a94 Robert Snedegar | Add missing methods on Edge (golang#166) * 0738b43 Robert Snedegar | Fix Loop contains which contained a missing negation and add test cases. (golang#156) * a9f12e8 dependabot[bot] | build(deps): bump github/codeql-action from 3.28.15 to 3.28.16 (golang#164) * 8f26a2e Alan Strohm | go.yml: use stable go-version (golang#162) * 7fd717b cui fliter | all: fix some comments (golang#161) * 8769abd Robert Snedegar | Update scorecard.yml with full version comment on Upload to code-scan… (golang#160) * 5905ce1 dependabot[bot] | build(deps): bump github/codeql-action from 3.28.13 to 3.28.15 (golang#159) * a33ded6 dependabot[bot] | build(deps): bump actions/upload-artifact from 4.6.1 to 4.6.2 (golang#158) * 5859d1c StepSecurity Bot | [StepSecurity] Apply security best practices (golang#155) * b9a2fb8 Robert Snedegar | Fix identified linter errors preventing errorlint, exhaustive, inamedparam, and staticcheck from running and enable those checks. (golang#153) ``` --------- Signed-off-by: StepSecurity Bot <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: cuishuang <[email protected]> Co-authored-by: Robert Snedegar <[email protected]> Co-authored-by: Alan Strohm <[email protected]> Co-authored-by: StepSecurity Bot <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cui fliter <[email protected]> Co-authored-by: Panmari <[email protected]> Co-authored-by: Jesse Rosenstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shape.go had fallen behind C++. Added the missing edge methods. Add comments on what's left to catch back up. (This is needed for src/s2/internal/s2incident_edge_tracker to get to LegacyValidationQuery)