PR - fix several outstanding PR's without CLA. #132
Conversation
Fix typos. Fix unneeded cast. Replace loop append with append ... Fix missing compare in a unit test.
| @@ -79,7 +79,7 @@ to geography are not part of the core library (e.g. easting/northing | |||
| conversions, ellipsoid approximations, geodetic vs. geocentric coordinates, | |||
| etc). | |||
|
|
|||
| See http://godoc.org/github.com/golang/geo for specific package documentation. | |||
| See http://pkg.go.dev/github.com/golang/geo for specific package documentation. | |||
There was a problem hiding this comment.
Most of this does not match the PR description.
There was a problem hiding this comment.
There are 3 commits that have gotten smashed together. I'm still trying to figure out the mapping from how easy things worked in g4 to how less intuitive git works. ( I'm still trying to undo a commit == a CL model of things)
This was an attempt to patch in several pull requests that did NOT have CLA so they could be all put in and get closed.
There was a problem hiding this comment.
This was an attempt to patch in several pull requests that did NOT have CLA so they could be all put in and get closed.
I don't think we can do that.
#91 should be good to merge, if it's really the right solution.
I will try to get the others into shape.
There was a problem hiding this comment.
I'm still trying to figure out the mapping from how easy things worked in g4 to how less intuitive git works. ( I'm still trying to undo a commit == a CL model of things)
You can probably fine some p4/git cheat sheets to help. You might want to try jj, since it's more Mercurial-like.
rsned
changed the title
Which PR is this? |
|
All PRs have been tickled. I think all but one have a CLA. |
ppc64le - Fix deviation in floating point values caused by FMA
Fix godoc url in README.
Fix a few random lint issues.