Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChainInterpolationQuery #110

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

pavlov061356
Copy link

Hello, I have looked through your repository and, unfortunately, I haven't found a contribution guide. So, I welcome your suggestions.

Here, in this pull request, I have rewritten the S2ChainInterpolationQuery class as a golang struct with all the features and tests from the C++ library. Additionally, I have added a method for computing a "divided slice", just like the POSTGIS function ST_LineInterpolatePoints, but with the addition of chain edges to the resulting slice.

@jmr jmr changed the title S2: ChainInterpolationQuery Add ChainInterpolationQuery Apr 3, 2025
@jmr
Copy link
Collaborator

jmr commented Apr 11, 2025

Are you still interested in this? There are conflicts that need to be resolved.

@pavlov061356
Copy link
Author

Are you still interested in this? There are conflicts that need to be resolved.

Yes, i am, i will resolve conflicts soon.

@pavlov061356
Copy link
Author

Finished with conflicts

@pavlov061356
Copy link
Author

LGTM

go.mod Outdated
@@ -1,4 +1,4 @@
module github.com/golang/geo
module github.com/pavlov061356/geo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're changing every file, which makes it hard to see where the real changes are.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@jmr
Copy link
Collaborator

jmr commented Apr 11, 2025

Additionally, I have added a method for computing a "divided slice", just like the POSTGIS function ST_LineInterpolatePoints, but with the addition of chain edges to the resulting slice.

Can you reduce this PR to just ChainInterpolationQuery? It will make it easier to review and we need think more before taking anything that gets the C++/Java/Go libraries out of sync.

@pavlov061356
Copy link
Author

Additionally, I have added a method for computing a "divided slice", just like the POSTGIS function ST_LineInterpolatePoints, but with the addition of chain edges to the resulting slice.

Can you reduce this PR to just ChainInterpolationQuery? It will make it easier to review and we need think more before taking anything that gets the C++/Java/Go libraries out of sync.

Already removed

@pavlov061356 pavlov061356 requested a review from jmr April 11, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants