-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChainInterpolationQuery #110
base: master
Are you sure you want to change the base?
Add ChainInterpolationQuery #110
Conversation
Are you still interested in this? There are conflicts that need to be resolved. |
Yes, i am, i will resolve conflicts soon. |
Finished with conflicts |
LGTM |
go.mod
Outdated
@@ -1,4 +1,4 @@ | |||
module github.com/golang/geo | |||
module github.com/pavlov061356/geo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're changing every file, which makes it hard to see where the real changes are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
Can you reduce this PR to just ChainInterpolationQuery? It will make it easier to review and we need think more before taking anything that gets the C++/Java/Go libraries out of sync. |
Already removed |
Hello, I have looked through your repository and, unfortunately, I haven't found a contribution guide. So, I welcome your suggestions.
Here, in this pull request, I have rewritten the S2ChainInterpolationQuery class as a golang struct with all the features and tests from the C++ library. Additionally, I have added a method for computing a "divided slice", just like the POSTGIS function ST_LineInterpolatePoints, but with the addition of chain edges to the resulting slice.