-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/gorelease: migrated git status --porcelain to git diff #72
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
afd6a3c
to
e55eb3d
Compare
This PR (HEAD: e55eb3d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/exp/+/560675. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
Message from [email protected]: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
The expectation of this application is that it is to be utilized in release pipelines. Due to this expectation, pipelines utilize volume mounting to transfer artifacts (untracked files) across different jobs (specifically referring to GITLAB here). This is a problem because git status --porcelain checks for untracked files and returns them as a list. This causes this pipeline to fail unexpectedly. In testing, `git reset --hard` will not remove these, while a `git clean -fdx` will correctly remove these files. I would recommend that in a follow-up commit there is an update to the available args for this cmd to control if untracked files are to be included or not (eg: --untracked)
e55eb3d
to
d0f001e
Compare
This PR (HEAD: d0f001e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/exp/+/560675. Important tips:
|
git status --porcelain
to git diff
Message from UnaffiliatedCode: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
Message from UnaffiliatedCode: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
Message from UnaffiliatedCode: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
Message from UnaffiliatedCode: Patch Set 4: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
Message from UnaffiliatedCode: Patch Set 4: -Code-Review (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
Message from UnaffiliatedCode: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/560675. |
The expectation of this application is that it is to be utilized in release
pipelines. Due to this expectation, pipelines utilize volume mounting to
transfer artifacts (untracked files) across different jobs (specifically
referring to GITLAB here).
This is a problem because git status --porcelain checks for untracked files
and returns them as a list. This causes this pipeline to fail unexpectedly.
In testing,
git reset --hard
will not remove these, while agit clean -fdx
will correctly remove these files.I would recommend that in a follow-up commit there is an update to the
available args for this cmd to control if untracked files are to be
included or not (eg: --untracked)