Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in Grafana dashboard path #424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed typo in Grafana dashboard path #424

wants to merge 1 commit into from

Conversation

johann8384
Copy link

No description provided.

@johann8384 johann8384 requested review from a team as code owners March 9, 2023 11:20
@OrlinVasilev
Copy link
Member

@johann8384 can you please fix the DCO and sing your commit

@OrlinVasilev
Copy link
Member

@johann8384 can you please fix the DCO signature
and we can merge this once we have this one done goharbor/harbor#16661

OrlinVasilev
OrlinVasilev requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the DCO

@OrlinVasilev
Copy link
Member

@johann8384 we are ready to merge that please fix your DCO so we can merge it thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrlinVasilev OrlinVasilev OrlinVasilev requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@wy65701436 wy65701436

@AllForNothing AllForNothing

@MinerYang MinerYang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johann8384 @OrlinVasilev @wy65701436 @AllForNothing @MinerYang