have option to enable robot full access #20754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20754 +/- ##
==========================================
+ Coverage 45.36% 50.07% +4.71%
==========================================
Files 244 247 +3
Lines 13333 13782 +449
Branches 2719 2847 +128
==========================================
+ Hits 6049 6902 +853
+ Misses 6983 6799 -184
+ Partials 301 81 -220
Flags with carried forward coverage won't be shown. Click here to find out more. |
When the system admin enable this option, the robot can be assigned with robot/user/group/quota permissions. Signed-off-by: wang yan <[email protected]>
stonezdj
reviewed
Jul 19, 2024
src/common/const.go
Outdated
| @@ -246,4 +246,7 @@ const ( | |||
|
|
|||
| // Global Leeway used for token validation | |||
| JwtLeeway = 60 * time.Second | |||
|
|
|||
| // Global Leeway used for token validation | |||
stonezdj
reviewed
Jul 19, 2024
src/common/rbac/const.go
Outdated
| if config.RobotFullAccess(ctx) { | ||
| permissionProvider = &NolimitProvider{} | ||
| } | ||
| return permissionProvider |
There was a problem hiding this comment.
if config.RobotFullAccess(ctx) {
return &NolimitProvider{}
}
return &BaseProvider{}
stonezdj
reviewed
Jul 19, 2024
src/common/rbac/const.go
Outdated
| var permissionProvider RobotPermissionProvider | ||
| permissionProvider = &BaseProvider{} | ||
| if config.RobotFullAccess(ctx) { | ||
| permissionProvider = &NolimitProvider{} |
stonezdj
approved these changes
Jul 19, 2024
Signed-off-by: wang yan <[email protected]>
Signed-off-by: wang yan <[email protected]>
Signed-off-by: wang yan <[email protected]>
Signed-off-by: wang yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the system admin enable this option, the robot can be assigned with robot/user/group/quota permissions.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: