feat: automatically generate the credentialName in the Login Component #147
+41
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t , suggestionFunc, PlaceholderFunc Signed-off-by: karanngi <[email protected]>
bupd
suggested changes
Aug 14, 2024
Comment on lines
+40
to
+42
| if loginView.Name == "" && loginView.Server != "" && loginView.Username != "" { | ||
| loginView.Name = fmt.Sprintf("%s@%s", loginView.Username, utils.SanitizeServerAddress(loginView.Server)) | ||
|
|
There was a problem hiding this comment.
this is redundant, please remove.
Suggested change
| if loginView.Name == "" && loginView.Server != "" && loginView.Username != "" { | |
| loginView.Name = fmt.Sprintf("%s@%s", loginView.Username, utils.SanitizeServerAddress(loginView.Server)) |
Comment on lines
65
to
66
| Validate(func(str string) error { | ||
| if str == "" { |
There was a problem hiding this comment.
Update Name of Credential validate block with this code
Suggested change
| Validate(func(str string) error { | |
| if str == "" { | |
| Validate(func(str string) error { | |
| if str == "" { | |
| loginView.Name = fmt.Sprintf("%s@%s", loginView.Username, utils.SanitizeServerAddress(loginView.Server)) | |
| return nil | |
| } | |
| return nil | |
| }), | |
This ensures that when Credential name is empty it is autofilled with the default value.
|
related #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Team,
This PR address the issue to automatically generate the credentialName in the Login Component.
Closes this #37