Enforce order for results with same confidence #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi gogs developers,
The current implementation utlizes go routines to speed up detection, which makes perfect sense.
But the consistency of result is not guaranteed when multiple detectors returning same confidence.
POC:
"ノエル"
withShift_JIS
=>"\x83m\x83G\x83\x8b"
DetectBest
Shift_JIS
,GB18030
andBig5
Because they all have the same confidence
10
DetectAll
Fix:
Result.order
fieldDetectBest
) based on confidence, if the confidence is same, sort based on order