fix(contrib/drivers/dm): support muti-line sql statement (#4163) #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanrentai 你好，你这个改动看起来没有什么问题的，但请提交对应的单测。此外，需要注意，多行的sql支持通常需要底层driver配置项的支持才能打开，因为容易产生sql注入的风险。 |
@sanrentai Hello, your changes seem to be nothing wrong, but please submit the corresponding single test. In addition, it should be noted that multi-line SQL support usually requires the support of the underlying driver configuration item to be opened, because it is easy to cause the risk of SQL injection. |
gqcn
added
the
missing unit testing cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.