-
-
Notifications
You must be signed in to change notification settings - Fork 23.4k
Fix copyright issues #112006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix copyright issues #112006
Conversation
| Files: misc/dist/linux/org.godotengine.Godot.appdata.xml | ||
| Comment: Linux AppStream Metadata File | ||
| Copyright: Copyright 2017-2022 Rémi Verschelde <[email protected]> | ||
| License: CC0-1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appstream metadata declares CC0-1.0 but the wildcard * stanza at the top was incorrectly assigning Expat/MIT.
| <metadata_license>CC0-1.0</metadata_license> |
| modules/betsy/bc1.glsl | ||
| modules/betsy/bc4.glsl | ||
| modules/betsy/bc6h.glsl | ||
| modules/betsy/CrossPlatformSettings_piece_all.glsl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't seem to exist anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was removed recently.
| modules/godot_physics_3d/joints/godot_hinge_joint_3d_sw.h | ||
| modules/godot_physics_3d/joints/godot_jacobian_entry_3d_sw.h | ||
| modules/godot_physics_3d/joints/godot_hinge_joint_3d.h | ||
| modules/godot_physics_3d/joints/godot_jacobian_entry_3d.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgotten to rename as part of cc39dca?
| platform/android/java/lib/src/main/java/org/godotengine/godot/input/InputManagerCompat.java | ||
| platform/android/java/lib/src/main/java/org/godotengine/godot/input/InputManagerV16.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files don't seem to exist anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were removed in 22ca5b2.
| Files: ./servers/rendering/renderer_rd/shaders/effects/tonemap.glsl | ||
| Files: servers/rendering/renderer_rd/shaders/effects/tonemap.glsl | ||
| Comment: NVidia's FXAA 3.11, simplified by Simon Rodriguez | ||
| Copyright: 2014-2015, NVIDIA CORPORATION | ||
| 2017 Simon Rodriguez | ||
| License: BSD-3-clause and Expat | ||
|
|
||
| Files: ./servers/rendering/renderer_rd/shaders/ss_effects_downsample.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssao_blur.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssao_importance_map.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssao_interleave.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssao.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssil_blur.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssil_importance_map.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssil_interleave.glsl | ||
| ./servers/rendering/renderer_rd/shaders/ssil.glsl | ||
| Files: servers/rendering/renderer_rd/shaders/effects/ss_effects_downsample.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssao_blur.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssao_importance_map.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssao_interleave.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssao.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssil_blur.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssil_importance_map.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssil_interleave.glsl | ||
| servers/rendering/renderer_rd/shaders/effects/ssil.glsl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor superfluous ./ cleanup (see point 2 in #101713) and path update.
| License: public-domain or Unlicense | ||
| License: Unlicense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public-domain isn't really a valid license, unless there is a License: public-domain stanza towards the end of the file that copies the public domain declaration verbatim from the source. Since all of these were also covered by the Unlicense, that seems more appropriate here.
Co-authored-by: Rémi Verschelde <[email protected]>
6784a57 to
8847cf7
Compare
|
Committed suggestion and squashed commits, thanks for reviewing! |
These came up while packaging 4.5.1 for Debian. I will comment individually on the changes with reasoning.