Skip to content

Conversation

@twrightsman
Copy link
Contributor

These came up while packaging 4.5.1 for Debian. I will comment individually on the changes with reasoning.

@twrightsman twrightsman requested a review from a team as a code owner October 24, 2025 18:05
Comment on lines 64 to 67
Files: misc/dist/linux/org.godotengine.Godot.appdata.xml
Comment: Linux AppStream Metadata File
Copyright: Copyright 2017-2022 Rémi Verschelde <[email protected]>
License: CC0-1.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appstream metadata declares CC0-1.0 but the wildcard * stanza at the top was incorrectly assigning Expat/MIT.

<metadata_license>CC0-1.0</metadata_license>

modules/betsy/bc1.glsl
modules/betsy/bc4.glsl
modules/betsy/bc6h.glsl
modules/betsy/CrossPlatformSettings_piece_all.glsl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't seem to exist anywhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was removed recently.

Comment on lines -82 to +87
modules/godot_physics_3d/joints/godot_hinge_joint_3d_sw.h
modules/godot_physics_3d/joints/godot_jacobian_entry_3d_sw.h
modules/godot_physics_3d/joints/godot_hinge_joint_3d.h
modules/godot_physics_3d/joints/godot_jacobian_entry_3d.h
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten to rename as part of cc39dca?

Comment on lines -129 to -130
platform/android/java/lib/src/main/java/org/godotengine/godot/input/InputManagerCompat.java
platform/android/java/lib/src/main/java/org/godotengine/godot/input/InputManagerV16.java
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files don't seem to exist anywhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were removed in 22ca5b2.

Comment on lines -154 to +170
Files: ./servers/rendering/renderer_rd/shaders/effects/tonemap.glsl
Files: servers/rendering/renderer_rd/shaders/effects/tonemap.glsl
Comment: NVidia's FXAA 3.11, simplified by Simon Rodriguez
Copyright: 2014-2015, NVIDIA CORPORATION
2017 Simon Rodriguez
License: BSD-3-clause and Expat

Files: ./servers/rendering/renderer_rd/shaders/ss_effects_downsample.glsl
./servers/rendering/renderer_rd/shaders/ssao_blur.glsl
./servers/rendering/renderer_rd/shaders/ssao_importance_map.glsl
./servers/rendering/renderer_rd/shaders/ssao_interleave.glsl
./servers/rendering/renderer_rd/shaders/ssao.glsl
./servers/rendering/renderer_rd/shaders/ssil_blur.glsl
./servers/rendering/renderer_rd/shaders/ssil_importance_map.glsl
./servers/rendering/renderer_rd/shaders/ssil_interleave.glsl
./servers/rendering/renderer_rd/shaders/ssil.glsl
Files: servers/rendering/renderer_rd/shaders/effects/ss_effects_downsample.glsl
servers/rendering/renderer_rd/shaders/effects/ssao_blur.glsl
servers/rendering/renderer_rd/shaders/effects/ssao_importance_map.glsl
servers/rendering/renderer_rd/shaders/effects/ssao_interleave.glsl
servers/rendering/renderer_rd/shaders/effects/ssao.glsl
servers/rendering/renderer_rd/shaders/effects/ssil_blur.glsl
servers/rendering/renderer_rd/shaders/effects/ssil_importance_map.glsl
servers/rendering/renderer_rd/shaders/effects/ssil_interleave.glsl
servers/rendering/renderer_rd/shaders/effects/ssil.glsl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor superfluous ./ cleanup (see point 2 in #101713) and path update.

Comment on lines -505 to +507
License: public-domain or Unlicense
License: Unlicense
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public-domain isn't really a valid license, unless there is a License: public-domain stanza towards the end of the file that copies the public domain declaration verbatim from the source. Since all of these were also covered by the Unlicense, that seems more appropriate here.

@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 24, 2025
@akien-mga akien-mga added this to the 4.6 milestone Oct 24, 2025
Co-authored-by: Rémi Verschelde <[email protected]>
@twrightsman
Copy link
Contributor Author

Committed suggestion and squashed commits, thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants