Add get_joint_rid() to PhysicalBone3D.
#112002
Open
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
get_joint_rid() to PhysicalBone3D.
|
(EDIT: Re: Check for class reference updates) What a clever little test. 👏 Was actually painfully aware I hadn't updated the docs - intending to simply copy the line from joint3d - but wasn't entirely sure how to go about it... having seen some other non documented methods in Production, and this being off my own initiative, I figured that might be for a later date. However, the error message indicates exactly where I need to update. Again, très clever. Will see if I can commit --amend when back at an actual computer later today. |
The-Cyber-Captain
force-pushed
the
expose-joint-rid-to-physical-bone-3d-13392
branch
from
94678d9 to
d83f28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Riordan-DCs approach and proposal, reflecting code found in the joint3D counterparts.
Given I was keen to see if this helps me in a project I'm currently developing, I implemented locally and gave it a test. Functions as I would expect, and doesn't appear to break anything. PR provided here just in case the engine does want to include the functionality.
Fixes godotengine/godot-proposals#13392