-
-
Notifications
You must be signed in to change notification settings - Fork 23k
Add a taskbar icon overlay for the editor window to tell if game window is paused or running #106583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add a taskbar icon overlay for the editor window to tell if game window is paused or running #106583
Conversation
63edf91
to
a05f230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the original app_icon is a PNG format. So should I also change that to SVG? |
Original is SVG, PNG is generated from it (it does not mean it should be auto generated on build, it can be done manually when it is changed, but source should be SVG): https://github.com/godotengine/godot/blob/master/icon.svg Unfortunately, there's no original SVG for macOS icons (only ICNS). |
Oh ok, so you're saying is I need to use a PNG that is exported manually from SVG, and the SVG is not required to be in the godot files. |
Unless, whoever made it still have it localy. |
@bruvzg What am I supposed to do for the macOS icon? I cannot find the code where it chooses a separate icon for the macOS. |
There's no code to select the icon, default icons are embedded into app bundle (on macOS) and executable (on Windows). ifdef can be used in this case: #ifdef MACOS_ENABLED
... set macos icon
#else
... set icon for the rest of icons
#endif |
For macOS, I need to save the image as PNG and not ICN right? |
ICNS is for embedding (for OS to see icon when app is not running), |
59dcfab
to
5a7694a
Compare
On macOS, it seems to be working fine, will check Windows and Linux later: Screen.Recording.2025-05-19.at.14.48.10.mov |
5a7694a
to
ab2b5b3
Compare
Moved the status icons to the top right of the icon. |
…ow is paused or running
ab2b5b3
to
b25e7e8
Compare
Closes godotengine/godot-proposals#12455
This thing work. But I am not sure if it is tidy or efficient.