[Windows] Fix left/right Shift key regression #101763
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #92415 and reported in #101384.
When multiple Shift keys are pressed, Windows only sends a KEYUP for the last key released, leaving the other stuck pressed. A workaround was introduced in #80231 to fake this missing KEYUP event.
However this workaround was broken in #92415. _get_mods() returns the modifier keys before the KEYUP, so there will always be a Shift key pressed before it's released.
This PR restores the original check and respective functionality. The MRP in #101384 can be used to reproduce and confirm the fix.
Thanks to @ghostsoft @andyprice @romlok for helping debug the issue.