Mention importance of thread-safety in Logger example
#11299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihe
added
enhancement
area:manual
mhilbrunner
approved these changes
Sep 18, 2025
Calinou
reviewed
Sep 18, 2025
Calinou
reviewed
Sep 18, 2025
mihe
force-pushed
the
logger-thread-safety
branch
from
a2735e9 to
b9ca083
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11266.
Given that not accommodating for the potential thread-safety concerns in these methods can crash the entire engine in the worst case, even when the user doesn't spin up any threads of their own, we should probably mention it in our example implementation.