-
-
Notifications
You must be signed in to change notification settings - Fork 75
Build Steam versions of macOS editor. #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| cp -r git/misc/dist/macos_tools.app Godot.app | ||
| mkdir -p Godot.app/Contents/MacOS | ||
| cp out/macos/steam/godot.macos.editor.universal Godot.app/Contents/MacOS/Godot | ||
| #cp libsteam_api.dylib Godot.app/Contents/Frameworks/libsteam_api.dylib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's an official public source to download these libs and how to handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the official download is: https://partner.steamgames.com/downloads/steamworks_sdk.zip
I cannot seem to download it properly with curl, but it redirects to a steamworks_sdk_162.zip and that seems to match a curlable URL (and a fixed version is better for reproducibility anyway).
https://partner.steamgames.com/downloads/steamworks_sdk_162.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these URLs don't seem to work from the command line, they're HTML pages with JavaScript and one needs to be logged in a Steam partner account to download the SDK.
Another option seems to be downloading from https://github.com/rlabrecque/SteamworksSDK - seems like this is (was?1) pretty much officially maintained by a Valve engineer, so it should be trustworthy.
Should we also copy the Windows DLLs at the same time so we ensure that we're using the same/latest version of the library in our Steam distribution?
--
Footnotes
-
Seems like he recently stopped working for Valve. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only load the lib, so version is pretty much irrelevant. The only reason to do it on macOS is signing, lib should be part of the bundle.
| cp out/macos/steam/godot.macos.editor.universal Godot.app/Contents/MacOS/Godot | ||
| #cp libsteam_api.dylib Godot.app/Contents/Frameworks/libsteam_api.dylib | ||
| chmod +x Godot.app/Contents/MacOS/Godot | ||
| zip -q -9 -r "${reldir}/${binname}_steam.zip" Godot.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should likely put it in another location than ${reldir}, otherwise we're going to upload it to our GitHub releases when it's not really relevant there. I guess just in the root folder (like we do with Godot.app) and then rm both after unzipping to the ${steamdir}.
See github.com/godotengine/godot/issues/111563