Fix face material lookup #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current exporter looks for materials in the mesh data block. In Blender materials can be either linked to the object or data which can create some confusion. Most of the time current version works, but it can fail in certain cases. The correct way is to use the face material_index to index into the material_slots-array. This should not break anything, but more testing could be useful.
I attached an "exportbug.zip" file which demonstrates the problem with Godot 3.0. If you export the .blend using the current addon you should notice that the cube has a red material in Godot instead of green despite both being green in Blender. Apply the patch, export, reimport and the cube should now be green and correct (remember to restart Blender to make sure the plugin is reloaded).
exportbug.zip