build: support specifying subset of platforms #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umarcor
force-pushed
the
umarcor/subset
branch
3 times, most recently
from
457a961 to
f67bf73
Compare
akien-mga
reviewed
Jun 8, 2023
| @@ -4,8 +4,10 @@ basedir=$(cd $(dirname "$0"); pwd) | |||
|
|
|||
| source $basedir/setup.sh | |||
|
|
|||
| platforms="linux,windows,web,android,osx,ios,msvc" | |||
There was a problem hiding this comment.
The msvc platform doesn't work currently, so it shouldn't be built by default. That's why it's disabled in main.
|
This is a pretty neat feature to have when building images from another SCons file. What is the status of this? How about removing the msvc from default platforms? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #121.Instead of building all the images when
./build.shis executed, this PR allows specifying a subset through a comma-separated list.