Skip to content

doc: fix Callable::from_sync_fn example using deprecated Result<T> return #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

doc: fix Callable::from_sync_fn example using deprecated Result<T> return #1347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions godot-core/src/builtin/callable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ impl Callable {
/// # use godot::prelude::*;
/// let callable = Callable::from_sync_fn("sum", |args: &[&Variant]| {
/// let sum: i32 = args.iter().map(|arg| arg.to::<i32>()).sum();
/// Ok(sum.to_variant())
/// sum
/// });
/// ```
#[cfg(feature = "experimental-threads")]
Expand Down Expand Up @@ -630,9 +630,7 @@ mod custom_callable {
pub trait RustCallable: 'static + PartialEq + Hash + fmt::Display + Send + Sync {
/// Invokes the callable with the given arguments as `Variant` references.
///
/// Return `Ok(...)` if the call succeeded, and `Err(())` otherwise.
/// Error handling is mostly needed in case argument number or types mismatch.
#[allow(clippy::result_unit_err)] // TODO remove once there's a clear error type here.
/// Errors are supported via panics.
fn invoke(&mut self, args: &[&Variant]) -> Variant;

// TODO(v0.5): add object_id().
Expand Down
Loading