Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse doc strings with litrs #1015

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adalinesimonian
Copy link

Fixes #885

Screenshot

@lilizoey lilizoey added bug c: register Register classes, functions and other symbols to GDScript labels Jan 18, 2025
@lilizoey
Copy link
Member

is there a way you could add a test for this case to verify that it's fixed?

@adalinesimonian
Copy link
Author

adalinesimonian commented Jan 18, 2025

register_docs_test.rs checks the formatting and would catch this case, the test just needs to be updated since right now it would fail expecting a ´\"´. I'm changing the test in PR #1017 so there may be a conflict between these two PRs, I can update the test here and then resolve the conflict in the other branch after this one is merged given that this one is small and easier to review, or I could do it the other way and leave this branch until the other one is merged and then rebase onto main and patch the fix. Any preference one way or another?

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: register Register classes, functions and other symbols to GDScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quotes from doc comments are unnecessarily escaped
3 participants