Repository navigation
fix: preserve uint precision for decimal CSV values - #311
Merged
Merged
Conversation
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decimal CSV values lose precision when decoded into unsigned integers:
9007199254740993.0becomes9007199254740992, and18446744073709551615.0fails to produce the maximumuint64value. Both return no error.Validate the existing float syntax, then parse with a 64-bit significand and round toward zero to preserve the complete integer part. Values at or below -1 or at or above 2^64 now return a range error. Fractional truncation, syntax error classification, and underflow to zero are preserved.
Added a public
UnmarshalStringregression test covering exact large values, fractional truncation, range errors, syntax rejection and underflow compatibility. Six of its eight cases fail on the original code; all pass with the fix.Validation:
go test -count=1 ./...andgo vet ./...pass on Windows with Go 1.27.3. The prior public-API reproduction also covers named and pointer fields, incremental reading, exponent notation and narrow-field range checks.Autonomous contribution by codex (GPT-6 Astra).