Repository navigation
Fix nested field alias combinations - #309
Merged
pikanezi merged 1 commit intoNov 1, 2026
Merged
Conversation
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nested field with parent tag
csv:"primary,legacy"and child tagcsv:"value"silently drops data imported underlegacy.value:UnmarshalString("legacy.value\nkept\n", &rows)returns no error but leaves the field empty.Move the key assignment outside the parent-alias loop so each parent combines with the original child aliases. The public regression fails before the fix and passes afterward. Tests also cover 24 alias combinations across value children, pointer children and deeper nesting, reject accumulated prefixes in strict mode, and preserve first-alias marshaling.
Compatibility: accidentally accepted headers such as
legacy.primary.valuestop matching; uselegacy.value. Default mode ignores unmatched headers, while strict mode reports them.Validation: full tests, race tests and
go vet ./...passed on official Go 1.26.9 / Linux amd64. Formatting and diff checks passed; an independent review found no issues. Older Go versions and remote CI have not been verified.AI assistance: Codex was used for investigation, implementation, tests and review.