Repository navigation
Fix headerless channel decoding of extra columns - #306
Merged
pikanezi merged 1 commit intoOct 12, 2026
Merged
Conversation
Match headerless slice decoding when rows contain more columns than the destination struct.
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
UnmarshalToChanWithoutHeaders panics when a row has more columns than the destination struct.
For example, a row containing
first,1,ignoredpanics when decoding a struct with two CSV fields.UnmarshalWithoutHeaders already ignores the extra column after #287.
This applies the same bounds check to the channel decoder.
Tests cover value and pointer records, nested pointer fields and quoted extra columns.
They also check shorter rows, conversion errors and reader errors.
The four extra column cases panic before the fix.
Checked with
go test -v ./...on Go 1.21.13 and 1.23.4.go test -race ./...,go build -v ./...andgo vet ./...pass on Go 1.23.4.Go 1.13.15 cannot compile types.go because it calls reflect.Value.SetZero.
Untouched master has the same compilation error.