Add support for Rails 8.1. Drop support for Rails 7.0, 7.1 and Ruby 3.1#139
Merged
JoeSouthan merged 2 commits intomasterfrom Dec 8, 2025
Merged
Add support for Rails 8.1. Drop support for Rails 7.0, 7.1 and Ruby 3.1#139JoeSouthan merged 2 commits intomasterfrom
JoeSouthan merged 2 commits intomasterfrom
Conversation
https://endoflife.date/rails https://endoflife.date/ruby After rails/rails#53689, not using kwargs is deprecated as of Rails 8.2.
jamiecobbett
reviewed
Dec 3, 2025
.github/workflows/tests.yml
Outdated
| exclude: | ||
| - ruby-version: "3.1" | ||
| rails-version: "8.0" | ||
| ruby-version: ["3.2", "3.3", "3.4"] |
Contributor
There was a problem hiding this comment.
I predict 3.5 appearing in oh, 22 days 🔮
jamiecobbett
approved these changes
Dec 3, 2025
Contributor
jamiecobbett
left a comment
jamiecobbett
left a comment
There was a problem hiding this comment.
My gut says we should test this with an existing coach app, but I'm guessing that's how you discovered the issue?
Contributor
Author
|
@jamiecobbett Yep, tested it with the main app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://endoflife.date/rails
https://endoflife.date/ruby
After rails/rails#53689, not using kwargs is
deprecated as of Rails 8.2.