Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include dependencies from the csproj in the project_path to review #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Critical-Impact
Copy link

@Critical-Impact Critical-Impact commented Oct 14, 2024

The PR adjusts the way that Plogon collects the nuget packages that are listed to review. It does this by restoring all the packages but only adding the ones that are collected from the csproj within the project_path provided by the plugin. If no project_path is provided in the plugin's manifest, it'll include every package as it was doing before.

The primary use case for this is when you have a structure like this

PrimaryPlugin/PrimaryPlugin.csproj - Only includes TertiaryLibrary.csproj
TertiaryLibrary/TertiaryLibrary.csproj
NotIncluded/NotIncluded.csproj

Before the changes it'd pick up the nuget packages on all 3 csproj files, but after it only picks up the nuget packages on PrimaryPlugin and TertiaryLibrary.

@goaaats
Copy link
Member

goaaats commented Oct 23, 2024

Is there a reason we are still downloading dependencies from lockfiles outside the project path altogether? Is it necessary for the build? At the very least, I think we should not download things we aren't also tracking, since that defeats the purpose of it a little bit IMO. Code looks good otherwise!

@Critical-Impact
Copy link
Author

Sorry, missed this comment
From what I recall(and I can give it another go) removing the other dependencies appeared to break the build process even if they weren't used in the final artifact. It might be possible to have it not download them, I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants