Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3494301: Event address format should be displayed in a different format #4255

Conversation

vcsvinicius
Copy link
Contributor

@vcsvinicius vcsvinicius commented Dec 16, 2024

Problem (for internal)

In the event page we show the event address.
The format is different than the one we show on group pages and we display the Country code instead of the country name.

Correct format and order of the fields should be: Location • Street, zip code city, country (full name)
Note that there is no comma between the city and the zip code when both values are provided

Solution (for internal)

I created a display-plugin to address type-field and it will format the address as a site-manager user had defined on admin pages.

Two new admin pages was created with different permissions.

  1. Page to define the address format;
  2. Page to define regex pattern from address (This page is more technical and should be used only with knowledge);

Release notes (to customers)

The address field can be controlled how they will be rendered to the end-user in event page and that format can be controlled by site-manager.

Issue tracker

PROD-30807
#3494301

Theme issue tracker

N/A

How to test

  • Log in as site-manager
  • Go to Address Format page "/admin/config/opensocial/address-settings/format" and check if exist an template register
  • Create an event
  • Check address field on header, it should follow the template registered on Address Format page
  • Change the Address Format
  • Clear cache
  • Check if format changed on Event page as well
  • If the new template register to address has a new pattern, example a value between parentheses, it should be registered on Regex Pattern page by an admin user

Change Record

N/A

Translations

N/A

@vcsvinicius vcsvinicius added type: feature Adds a new feature to Open Social status: needs review This pull request is waiting for a requested review prio: medium team: guardians labels Dec 16, 2024
@vcsvinicius vcsvinicius added this to the 13.0.0-alpha21 milestone Dec 16, 2024
@vcsvinicius vcsvinicius requested a review from a team December 16, 2024 17:37
@vcsvinicius vcsvinicius force-pushed the issue/3494301/change-address-on-pre-process-at-event-page branch from 66179f7 to da43ba4 Compare December 18, 2024 19:19
@vcsvinicius vcsvinicius force-pushed the issue/3494301/change-address-on-pre-process-at-event-page branch 2 times, most recently from 4242fd8 to cee72e3 Compare December 19, 2024 13:07
@vcsvinicius vcsvinicius force-pushed the issue/3494301/change-address-on-pre-process-at-event-page branch from cee72e3 to 96501de Compare December 19, 2024 14:58
@vcsvinicius
Copy link
Contributor Author

I am closing this pull-request and opened a new one to fit with new structure: https://github.com/goalgorilla/cablecar/pull/2560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: medium status: needs review This pull request is waiting for a requested review team: guardians type: feature Adds a new feature to Open Social
Development

Successfully merging this pull request may close these issues.

2 participants