Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3458767: Remove the redundant "Content access" filter from views #4121

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Issue #3458767: Remove the redundant "Content access" filter from views #4121

merged 1 commit into from
Dec 20, 2024

Conversation

nechai
Copy link
Contributor

@nechai nechai commented Oct 17, 2024

Caution

PR should be merged in #3961

Note

This PR doesn't require behat tests passing. Tests should be checked in #3961

Remove the redundant "Content access" filter from views.
More details about the reasons why we need this PR can be found at #4098

@nechai nechai self-assigned this Oct 17, 2024
@nechai nechai mentioned this pull request Oct 17, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Thanks for opening this Pull Request! To ensure Pull Requests are easy to find and understand for all our team-members we've established some standardised rules. While reviewing this pull request I've found the following issues, please resolve them.

Missing milestone
The issue is missing a milestone. Milestones are important to help release managers know whether they might need to postpone a release for a critical issue and to communicate what fixes and new features are included in a release. Before merging, please select the appropriate milestone for this pull request.

🤖 This is an automatically produced message by the Open Social PR manager.

@nechai nechai force-pushed the feature/3458767-replace-node-grants branch from 3b2a0de to b52e1bb Compare November 7, 2024 11:14
@nechai nechai force-pushed the feature/remove-node-grants-views-filters branch from 705ee5b to 7ef8677 Compare November 7, 2024 11:34
tregismoreira
tregismoreira approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@tregismoreira tregismoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to review here. It's basically config changes. LGTM.

@nechai nechai force-pushed the feature/3458767-replace-node-grants branch from ec9b509 to a882e33 Compare December 20, 2024 10:18
@nechai nechai force-pushed the feature/remove-node-grants-views-filters branch from 7ef8677 to f189551 Compare December 20, 2024 10:22
@ribel ribel changed the title Remove the redundant "Content access" filter from views Issue #3458767: Remove the redundant "Content access" filter from views Dec 20, 2024
@ribel ribel added type: refactoring Updates code for improved maintenance without changing its functionality team: enterprise This PR originates from the ECI team prio: medium status: needs review This pull request is waiting for a requested review labels Dec 20, 2024
@ribel ribel merged commit f504afc into feature/3458767-replace-node-grants Dec 20, 2024
15 of 21 checks passed
@ribel ribel deleted the feature/remove-node-grants-views-filters branch December 20, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tregismoreira tregismoreira tregismoreira approved these changes

@ribel ribel ribel approved these changes

@volodymyr-sydor volodymyr-sydor Awaiting requested review from volodymyr-sydor

Assignees

@nechai nechai

Labels
prio: medium status: needs review This pull request is waiting for a requested review team: enterprise This PR originates from the ECI team type: refactoring Updates code for improved maintenance without changing its functionality
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nechai @tregismoreira @ribel