Skip to content

MariaDB Metadata skipping and DEPRECATE_EOF #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2025
Merged

MariaDB Metadata skipping and DEPRECATE_EOF #1708

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1907645
MariaDB Metadata skipping
rusher Apr 24, 2025
9db718f
simplify
methane Apr 25, 2025
19dc2f7
shorter names
methane Apr 25, 2025
90db683
fix review points
methane Apr 25, 2025
ccdef72
stmt.Exec() should cache metadata
methane Apr 25, 2025
1ef9cde
modernize BenchmarkReceiveMetadata
methane Apr 25, 2025
2d18113
remove useless check since already done in readHandshakePacket()
rusher Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ func (c *connector) Connect(ctx context.Context) (driver.Conn, error) {
return nil, err
}

if mc.cfg.TLS != nil && serverCapabilities&clientSSL == 0 {
return nil, fmt.Errorf("TLS is required, but server doesn't support it")
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

if plugin == "" {
plugin = defaultAuthPlugin
}
Expand Down