Fix Metal Support #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making these libraries outside of the build directory causes them to have no knowledge that we're using metal. This prevents metal acceleration from working. Using the cmake build directory fixes this issue.
This example failed to load metal due to it missing the SetGPULayers option. I also updated the instructions to use go build instead of go run. This is due to go run not loading the ggml-metal.metal file. I was unable to get this working. Compiling it and running ./main will load the ggml-metal.metal file in the CWD.
mudler
approved these changes
Jun 10, 2023
|
Thanks @soleblaze ! nice catch! |
|
ok weird, CI on mac fails 🤔 |
For this to compile properly using metal we need to set some CGO_LDFLAGS so it can find the appropriate frameworks.
|
Fantastic, awesome job @soleblaze ! |
mudler
reviewed
Jun 10, 2023
| @@ -145,6 +145,7 @@ endif | |||
|
|
|||
| ifeq ($(BUILD_TYPE),metal) | |||
| EXTRA_LIBS= | |||
| CGO_LDFLAGS+="-framework Accelerate -framework Foundation -framework Metal -framework MetalKit -framework MetalPerformanceShaders" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the make file so that the object files are created via the build directory instead of in llama.cpp. This fixes the issue where libbinding.a had no knowledge of metal. #91
I also updated the example instructions for metal so that they work properly.